[Hippo-cms7-dev] [Hudson] Build failed in Hudson: hippo-addon-channel-manager Trunk » Addon Channel Manager Frontend #2023

Mathijs den Burger m.denburger at onehippo.com
Wed Jan 9 09:04:58 CET 2013


Hi Jannis (cc'd Arthur too, as Kanban Javascripter),

Since last week, we made the channel manager build (and also more and more
CMS artifacts) fail when jslint finds errors in the Javascript files. This
will force us to become less sloppy in Javascript (and hurt our feelings,
for sure :).

Note that IntelliJ also has jslint built in. Enable it for a project to get
realtime feedback while editing .js files (as I just posted on Yammer). See
http://blogs.jetbrains.com/idea/2012/05/lint-your-javascript-with-jslintjshint-in-real-time/.
I attached a screenshot of the jslint configuration I'm using for the
addon-channel-manager project. The jslint maven plugin configuration the
channel manager has kind-of the same settings as I use in IntelliJ, as you
can see in the pom. Note that we exclude copy-pasted javascript from
external sources (like the miframe sources).

So, can you please fix the channel manager build? And build before you
commit javascript changes to ensure jslint is happy :)

best,
Mathijs



On Tue, Jan 8, 2013 at 5:46 PM, Hippo Public Hudson Server <
beheer at onehippo.com> wrote:

> See <
> https://builds.onehippo.org/job/hippo-addon-channel-manager%20Trunk/org.onehippo.cms7$hippo-addon-channel-manager-frontend/2023/changes
> >
>
> Changes:
>
> [jbloemendal] CMS7-6814 Pre- and post- iframe-message handlers
>
> Adding exception handling.
>
> [jbloemendal] CMS7-6813 Template Composer overlapping containers
>
> The container's overlay position gets corrected by the border width, which
> creates an unnecessary offset and causes overlapping of containers.
>
> [jbloemendal] CMS7-6814 Pre- and post- iframe-message handlers
>
> Provide pre- and post-message handlers for:
>   - buildoverlay
>   - showoverlay
>   - hideoverlay
>   - resize
>
> ------------------------------------------
> [HUDSON] Archiving <
> https://builds.onehippo.org/job/hippo-addon-channel-manager%20Trunk/org.onehippo.cms7$hippo-addon-channel-manager-frontend/ws/-api/pom.xml>
> to /var/hudson-data/jobs/hippo-addon-channel-manager
> Trunk/modules/org.onehippo.cms7$hippo-addon-channel-manager-frontend-api/builds/2013-01-08_17-46-07/archive/org.onehippo.cms7/hippo-addon-channel-manager-frontend-api/2.24.01-SNAPSHOT/pom.xml
> [HUDSON] Archiving <
> https://builds.onehippo.org/job/hippo-addon-channel-manager%20Trunk/org.onehippo.cms7$hippo-addon-channel-manager-frontend/ws/-api/target/hippo-addon-channel-manager-frontend-api-2.24.01-SNAPSHOT.jar>
> to /var/hudson-data/jobs/hippo-addon-channel-manager
> Trunk/modules/org.onehippo.cms7$hippo-addon-channel-manager-frontend-api/builds/2013-01-08_17-46-07/archive/org.onehippo.cms7/hippo-addon-channel-manager-frontend-api/2.24.01-SNAPSHOT/hippo-addon-channel-manager-frontend-api-2.24.01-SNAPSHOT.jar
> [HUDSON] Archiving <
> https://builds.onehippo.org/job/hippo-addon-channel-manager%20Trunk/org.onehippo.cms7$hippo-addon-channel-manager-frontend/ws/-api/target/hippo-addon-channel-manager-frontend-api-2.24.01-SNAPSHOT-sources.jar>
> to /var/hudson-data/jobs/hippo-addon-channel-manager
> Trunk/modules/org.onehippo.cms7$hippo-addon-channel-manager-frontend-api/builds/2013-01-08_17-46-07/archive/org.onehippo.cms7/hippo-addon-channel-manager-frontend-api/2.24.01-SNAPSHOT/hippo-addon-channel-manager-frontend-api-2.24.01-SNAPSHOT-sources.jar
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building Addon Channel Manager Frontend 2.24.01-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-jquery/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-jquery/2.24.01-SNAPSHOT/maven-metadata.xml(1009 B at 9.5 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-editor-frontend/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-editor-frontend/2.24.01-SNAPSHOT/maven-metadata.xml(1018 B at 13.1 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-editor/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-editor/2.24.01-SNAPSHOT/maven-metadata.xml(616 B at 8.4 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-gallery-frontend/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-gallery-frontend/2.24.01-SNAPSHOT/maven-metadata.xml(1019 B at 15.5 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-gallery/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-gallery/2.24.01-SNAPSHOT/maven-metadata.xml(617 B at 6.8 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-workflowmenu/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-workflowmenu/2.24.01-SNAPSHOT/maven-metadata.xml(1015 B at 15.5 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-builtin/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-builtin/2.24.01-SNAPSHOT/maven-metadata.xml(1010 B at 6.7 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-translation-common/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-translation-common/2.24.01-SNAPSHOT/maven-metadata.xml(1021 B at 14.7 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-translation/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-translation/2.24.01-SNAPSHOT/maven-metadata.xml(621 B at 8.9 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-surf-frontend/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-surf-frontend/2.24.01-SNAPSHOT/maven-metadata.xml(1016 B at 12.4 KB/sec)
> Downloading:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-surf/2.24.01-SNAPSHOT/maven-metadata.xml
> Downloaded:
> http://maven.onehippo.com/maven2-snapshots/org/onehippo/cms7/hippo-cms-surf/2.24.01-SNAPSHOT/maven-metadata.xml(614 B at 10.0 KB/sec)
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @
> hippo-addon-channel-manager-frontend ---
> [INFO]
> [INFO] --- jslint-maven-plugin:1.0.1:jslint (default) @
> hippo-addon-channel-manager-frontend ---
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/channels/ChannelGridPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/channels/ChannelOverview.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/channels/ChannelIconPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/channels/ChannelPropertiesWindow.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/ExtStoreFuture.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/BlueprintListPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/plugins/vtabs/VerticalTabPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/plugins/colorfield/colorfield.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/plugins/floatingwindow/FloatingWindow.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/templatecomposerglobal.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/DragDropOne.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/Hippo.Msg.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/Notification.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/IconGridView.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/PageModelStore.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/RestStore.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/ToolkitGridPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/PropertiesPanel.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/PageContainer.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/PageContext.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/ToolkitStore.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/IconToolbarWindow.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/pageeditor/PageEditor.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/main.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/factory.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/surfandedit.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/util.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/widgets.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/templatecomposer/iframe/page.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/hstconfig/HstConfigEditor.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/hstconfig/ExtWireframe.js
> [INFO] Parsing:
> org/onehippo/cms7/channelmanager/common/MarkRequiredFields.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/widgets/ExtLinkPicker.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/BreadcrumbToolbar.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/RootPanel.js
> [INFO] Parsing: org/onehippo/cms7/channelmanager/ChannelFormPanel.js
> [ERROR] page.js:45:21:Combine this with the previous 'var' statement.
> [ERROR] page.js:46:21:Combine this with the previous 'var' statement.
> [ERROR] page.js:47:21:Combine this with the previous 'var' statement.
> [ERROR] page.js:62:30:'exception' is already defined.
> mojoFailed org.codehaus.mojo:jslint-maven-plugin:1.0.1(default)
> projectFailed
> org.onehippo.cms7:hippo-addon-channel-manager-frontend:2.24.01-SNAPSHOT
>
> --
> This message is automatically generated by Hudson.
> For more information on Hudson, see: http://hudson-ci.org/
> _______________________________________________
> Hippo-cms7-dev mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.onehippo.org/pipermail/hippo-cms7-dev/attachments/20130109/a8d78583/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: channel-manager-jslint-settings.png
Type: image/png
Size: 54701 bytes
Desc: not available
URL: <http://lists.onehippo.org/pipermail/hippo-cms7-dev/attachments/20130109/a8d78583/attachment.png>


More information about the Hippo-cms7-dev mailing list