[Hippo-cms7-user] Re: [HippoCMS-svn] [27862] hippo-cms7/repository: REPO-1: remove debug output

Ard Schrijvers a.schrijvers at onehippo.com
Mon Apr 18 17:01:38 CEST 2011


On Mon, Apr 18, 2011 at 4:58 PM, marijan milicevic
<m.milicevic at onehippo.com> wrote:
> Hi Ard,
>
> did you see the code changes:

I did but for some reason interpreted the + lines as - lines :-))

I think my mind was put on the wrong foot by the message.

Never mind my remark

Ard

>
>
>  if (category.getName().startsWith(CATAGORYNAMEPREFIX)) {
>>
>>  -                    System.err.println("inspect workflow for event
>> workflow events in category "+category.getName());
>>  +                   if (WorkflowManagerImpl.log.isDebugEnabled()) {
>>  +                        WorkflowManagerImpl.log.debug("inspect workflow
>> for event workflow events in category "+category.getName());
>>  +                   }
>
>
>
>
>
> On 04/18/2011 04:56 PM, Ard Schrijvers wrote:
>>
>> Is there a specific reason why the logging is removed? 'remove debug
>> output' doesn't really explain it to me (I am sure there is a good
>> reason, just wondering)
>>
>> Regards Ard
>>
>> On Mon, Apr 18, 2011 at 4:47 PM, bvanhalderen<svn-logs at onehippo.org>
>>  wrote:
>>>
>>> Revision: 27862
>>> Author:   bvanhalderen
>>> Date:     2011-04-18 16:47:01 +0200 (Mon, 18 Apr 2011)
>>> Log Message:
>>> -----------
>>> REPO-1: remove debug output
>>>
>>> Modified Paths:
>>> --------------
>>>
>>>  hippo-cms7/repository/trunk/engine/src/main/java/org/hippoecm/repository/impl/WorkflowPostActionsImpl.java
>>>
>>> Modified:
>>> hippo-cms7/repository/trunk/engine/src/main/java/org/hippoecm/repository/impl/WorkflowPostActionsImpl.java
>>> ===================================================================
>>> ---
>>> hippo-cms7/repository/trunk/engine/src/main/java/org/hippoecm/repository/impl/WorkflowPostActionsImpl.java
>>>  2011-04-18 14:45:15 UTC (rev 27861)
>>> +++
>>> hippo-cms7/repository/trunk/engine/src/main/java/org/hippoecm/repository/impl/WorkflowPostActionsImpl.java
>>>  2011-04-18 14:47:01 UTC (rev 27862)
>>> @@ -37,8 +37,9 @@
>>>     }
>>>
>>>     static WorkflowPostActions createPostActions(WorkflowManagerImpl
>>> workflowManager, String workflowCategory, Method workflowMethod, String
>>> sourceIdentity) {
>>> -       //if (WorkflowManagerImpl.log.isDebugEnabled()) {
>>> -        System.err.println("inspect workflow for event workflow upon
>>> "+workflowCategory+":"+workflowMethod.toString());
>>> +       if (WorkflowManagerImpl.log.isDebugEnabled()) {
>>> +            WorkflowManagerImpl.log.debug("inspect workflow for event
>>> workflow upon "+workflowCategory+":"+workflowMethod.toString());
>>> +       }
>>>         if (workflowMethod.getName().equals("hints") ||
>>> workflowCategory.startsWith(CATAGORYNAMEPREFIX) ||
>>> workflowCategory.equals("internal")) {
>>>             return null;
>>>         }
>>> @@ -47,12 +48,16 @@
>>>             for (NodeIterator categories =
>>> workflowManager.rootSession.getNodeByIdentifier(workflowManager.configuration).getNodes();
>>> categories.hasNext();) {
>>>                 Node category = categories.nextNode();
>>>                 if (category.getName().startsWith(CATAGORYNAMEPREFIX)) {
>>> -                    System.err.println("inspect workflow for event
>>> workflow events in category "+category.getName());
>>> +                   if (WorkflowManagerImpl.log.isDebugEnabled()) {
>>> +                        WorkflowManagerImpl.log.debug("inspect workflow
>>> for event workflow events in category "+category.getName());
>>> +                   }
>>>                     Node wfSubject =
>>> workflowManager.rootSession.getNodeByIdentifier(sourceIdentity);
>>>                     try {
>>>                         Node wfNode =
>>> workflowManager.getWorkflowNode(category.getName(), wfSubject,
>>> workflowManager.rootSession);
>>>                         if (wfNode != null) {
>>> -                            System.err.println("inspect workflow for
>>> event workflow selected "+wfNode.getPath());
>>> +                           if (WorkflowManagerImpl.log.isDebugEnabled())
>>> {
>>> +                                WorkflowManagerImpl.log.debug("inspect
>>> workflow for event workflow selected "+wfNode.getPath());
>>> +                           }
>>>                             WorkflowPostActions action = new
>>> WorkflowPostAction(workflowManager, wfSubject,
>>>
>>> Document.class.isAssignableFrom(workflowMethod.getReturnType()), wfNode,
>>>                                     workflowCategory,
>>> workflowMethod.getName());
>>>
>>> _______________________________________________
>>> Hippocms-svn mailing list
>>> Hippocms-svn at lists.hippocms.org
>>> http://lists.hippo.nl/mailman/listinfo/hippocms-svn
>>>
>>
>
> _______________________________________________
> Hippo-cms7-user mailing list and forums
> http://www.onehippo.org/cms7/support/forums.html
>



-- 
Hippo
Europe  •  Amsterdam  Oosteinde 11  •  1017 WT Amsterdam  •  +31 (0)20 522 4466
USA  • San Francisco 755 Baywood Drive, Second Floor •  Petaluma, CA.
94954 •  +1 877 414 4776 (toll free)
Canada    •   Montréal  5369 Boulevard St-Laurent #430 •  Montréal QC
H2T 1S5  •  +1 (514) 316 8966
www.onehippo.com  •  www.onehippo.org  •  info at onehippo.com
________________________________________________________________
This e-mail may be privileged and/or confidential, and the sender does
not waive any related rights and obligations. Any distribution, use or
copying of this e-mail or the information it contains by other than an
intended recipient is unauthorized. If you received this e-mail in
error, please advise me (by return e-mail or otherwise) immediately.



More information about the Hippo-cms7-user mailing list